Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deps] AC: Update style-loader to v4 #10589

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[deps] AC: Update style-loader to v4 #10589

wants to merge 1 commit into from
+24 −7

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 19, 2024 •
edited
Loading

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
style-loader 3.3.4 -> 4.0.0 age adoption passing confidence

Release Notes

webpack-contrib/style-loader (style-loader)

v4.0.0

Compare Source

⚠ BREAKING CHANGES
  • minimum supported webpack version is 5.27.0
  • minimum support Node.js version is 18.12.0
  • the insert option can only be a selector or the path to the module

Migration:

Before:

webpack.config.js

module.exports = {
  module: {
    rules: [
      {
        test: /\.css$/i,
        use: [
          {
            loader: "style-loader",
            options: {
              injectType: "styleTag",
              styleTagTransform: function (css, style) {
                // Do something ...
                style.innerHTML = `${css}.modify{}\n`;

                document.head.appendChild(style);
              },
            },
          },
          "css-loader",
        ],
      },
    ],
  },
};

After:

insert-function.js

function insert(css, style) {
  var parent = options.target || document.head;

  parent.appendChild(element);
}

module.exports = insert;

webpack.config.js

module.exports = {
  module: {
    rules: [
      {
        test: /\.css$/i,
        use: [
          {
            loader: "style-loader",
            options: {
              insert: require.resolve("./insert.js"),
            },
          },
          "css-loader",
        ],
      },
    ],
  },
};
  • the styleTagTransform option can only be the path to the module

Migration:

Before:

webpack.config.js

module.exports = {
  module: {
    rules: [
      {
        test: /\.css$/i,
        use: [
          {
            loader: "style-loader",
            options: {
              injectType: "styleTag",
              styleTagTransform: function (css, style) {
                // Do something ...
                style.innerHTML = `${css}.modify{}\n`;

                document.head.appendChild(style);
              },
            },
          },
          "css-loader",
        ],
      },
    ],
  },
};

After:

style-tag-transform-function.js

function styleTagTransform(css, style) {
  // Do something ...
  style.innerHTML = `${css}.modify{}\n`;

  document.head.appendChild(style);
}

module.exports = styleTagTransform;

webpack.config.js

module.exports = {
  module: {
    rules: [
      {
        test: /\.css$/i,
        use: [
          {
            loader: "style-loader",
            options: {
              styleTagTransform: require.resolve("./style-tag-transform-function.js"),
            },
          },
          "css-loader",
        ],
      },
    ],
  },
};
Bug Fixes
3.3.3 (2023-05-19)
Bug Fixes
3.3.2 (2023-03-13)
Bug Fixes
3.3.1 (2021-10-21)
Bug Fixes

Configuration

📅 Schedule: Branch creation - "every 2nd week starting on the 2 week of the year before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested review from a team and vincentsalucci August 19, 2024 01:29
@bitwarden-bot bitwarden-bot changed the title [deps] AC: Update style-loader to v4 [AC-2985] [deps] AC: Update style-loader to v4 Aug 19, 2024
@bitwarden-bot
Copy link

Internal tracking:

@codecov Codecov
Copy link

codecov bot commented Aug 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.42%. Comparing base (5592d64) to head (51f758c).

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10589   +/-   ##
=======================================
  Coverage   33.41%   33.42%           
=======================================
  Files        2841     2841           
  Lines       89008    89008           
  Branches    16979    16979           
=======================================
+ Hits        29744    29751    +7     
+ Misses      56927    56920    -7     
  Partials     2337     2337

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate renovate bot changed the title [AC-2985] [deps] AC: Update style-loader to v4 [deps] AC: Update style-loader to v4 Aug 19, 2024
@renovate renovate bot force-pushed the renovate/style-loader-4.x branch 2 times, most recently from cb00b75 to a975b58 Compare August 23, 2024 14:21
@renovate renovate bot force-pushed the renovate/style-loader-4.x branch from a975b58 to b4f5f85 Compare August 29, 2024 14:09
@renovate renovate bot force-pushed the renovate/style-loader-4.x branch from a6085fb to 394d79a Compare October 3, 2024 21:46
@renovate renovate bot force-pushed the renovate/style-loader-4.x branch from 394d79a to b4e7d86 Compare October 17, 2024 13:16
@renovate renovate bot force-pushed the renovate/style-loader-4.x branch from b4e7d86 to f3a176a Compare November 4, 2024 17:06
@renovate renovate bot force-pushed the renovate/style-loader-4.x branch from f3a176a to 98bd9b2 Compare November 11, 2024 21:52
@renovate renovate bot force-pushed the renovate/style-loader-4.x branch from 98bd9b2 to 51f758c Compare November 12, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentsalucci vincentsalucci Awaiting requested review from vincentsalucci vincentsalucci was automatically assigned from bitwarden/team-admin-console-dev

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bitwarden-bot